Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdosqlexec] Added more attributes. #1631

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Aug 23, 2021

  • Added attribute keepformat
  • Added attribute expandproperties
  • Added formatter attribute showtrailers

This will be documented in phingofficial/guide#39

@siad007 siad007 added this to the 3.0.0-RC3 milestone Aug 23, 2021
@siad007 siad007 self-assigned this Aug 23, 2021
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #1631 (a2d6245) into main (c100f9d) will increase coverage by 0.23%.
The diff coverage is 88.00%.

❗ Current head a2d6245 differs from pull request most recent head 2fe5713. Consider uploading reports for the commit 2fe5713 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1631      +/-   ##
============================================
+ Coverage     57.67%   57.91%   +0.23%     
- Complexity     6934     6954      +20     
============================================
  Files           355      355              
  Lines         16793    16829      +36     
============================================
+ Hits           9685     9746      +61     
+ Misses         7108     7083      -25     
Impacted Files Coverage Δ
src/Phing/Task/System/Pdo/PDOSQLExecTask.php 78.35% <64.28%> (+2.94%) ⬆️
...rc/Phing/Task/System/Pdo/DummyPDOQuerySplitter.php 90.47% <87.50%> (-2.86%) ⬇️
.../Phing/Task/System/Pdo/DefaultPDOQuerySplitter.php 98.00% <100.00%> (+0.17%) ⬆️
src/Phing/Task/System/Pdo/PDOQuerySplitter.php 100.00% <100.00%> (ø)
...ing/Task/System/Pdo/PDOSQLExecFormatterElement.php 69.33% <100.00%> (+2.19%) ⬆️
.../Phing/Task/System/Pdo/PlainPDOResultFormatter.php 94.59% <100.00%> (+75.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c100f9d...2fe5713. Read the comment docs.

@siad007 siad007 merged commit 14c5bbe into phingofficial:main Aug 23, 2021
@siad007 siad007 deleted the PDOAdditions branch August 23, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant